From f90eb94484cbd4d7abc449596b7cf3a65ccf66dd Mon Sep 17 00:00:00 2001 From: Riley McArdle Date: Thu, 21 Feb 2013 22:23:58 -0600 Subject: [PATCH 1/5] Fix issue MR-322 - Connection Button not listing servers --- CHANGELOG.TXT | 1 + mRemoteV1/Forms/frmMain.vb | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.TXT b/CHANGELOG.TXT index bb136e8ae..e1cd5610a 100644 --- a/CHANGELOG.TXT +++ b/CHANGELOG.TXT @@ -3,6 +3,7 @@ Fixed issue MR-317 - Difficulty right-clicking on Tab Fixed issue MR-318 - Wrong tab gets selected when tab names overflow on the tab bar Fixed issue MR-321 - New connection panel doesn't get panel header if its the only one or is moved + Fixed issue MR-322 - Connection Button not listing servers Added option to always show panel tabs Fixed "Decryption failed. Padding is invalid and cannot be removed." notification. diff --git a/mRemoteV1/Forms/frmMain.vb b/mRemoteV1/Forms/frmMain.vb index 9a9c0f397..33a1300ef 100644 --- a/mRemoteV1/Forms/frmMain.vb +++ b/mRemoteV1/Forms/frmMain.vb @@ -685,8 +685,6 @@ Public Class frmMain End If AddHandler tMenItem.MouseDown, AddressOf ConMenItem_MouseDown - - tMenItem.Dispose() Next Catch ex As Exception MessageCollector.AddMessage(Messages.MessageClass.ErrorMsg, "AddNodeToMenu failed" & vbNewLine & ex.Message, True) From 1f776fb9bf8366c133e619903dffaef4b7a70f89 Mon Sep 17 00:00:00 2001 From: Riley McArdle Date: Thu, 21 Feb 2013 23:54:29 -0600 Subject: [PATCH 2/5] Add timeout to WaitForInputIdle in Connection.Protocol.PuttyBase.Connect(). --- mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb index 6d37da5ce..68738e360 100644 --- a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb +++ b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb @@ -156,7 +156,7 @@ Namespace Connection AddHandler PuttyProcess.Exited, AddressOf ProcessExited PuttyProcess.Start() - PuttyProcess.WaitForInputIdle() + PuttyProcess.WaitForInputIdle(My.Settings.MaxPuttyWaitTime * 1000) Dim startTicks As Integer = Environment.TickCount While PuttyHandle.ToInt32 = 0 And Environment.TickCount < startTicks + (My.Settings.MaxPuttyWaitTime * 1000) From c29c5015d510e097e2b39095e20d2119857fd000 Mon Sep 17 00:00:00 2001 From: Riley McArdle Date: Thu, 21 Feb 2013 23:58:04 -0600 Subject: [PATCH 3/5] Fixed issue MR-229 - Integrated PuTTY doesn't work in Windows 8 RP Fixed issue MR-264 - Windows 8 support --- CHANGELOG.TXT | 2 ++ mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb | 3 +++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.TXT b/CHANGELOG.TXT index e1cd5610a..7882723fb 100644 --- a/CHANGELOG.TXT +++ b/CHANGELOG.TXT @@ -1,5 +1,7 @@ Fixed issue MR-183 - Error trying to save connections when using SQL - Invalid column name _parentConstantId Fixed issue MR-225 - Tabs do not open in a panel until multiple panels are displayed. + Fixed issue MR-229 - Integrated PuTTY doesn't work in Windows 8 RP + Fixed issue MR-264 - Windows 8 support Fixed issue MR-317 - Difficulty right-clicking on Tab Fixed issue MR-318 - Wrong tab gets selected when tab names overflow on the tab bar Fixed issue MR-321 - New connection panel doesn't get panel header if its the only one or is moved diff --git a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb index 68738e360..63ce21209 100644 --- a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb +++ b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb @@ -265,6 +265,9 @@ Namespace Connection End Function Public Shared Function IsFilePuttyNg(file As String) As Boolean + ' PuTTYNG enhancements are not yet compatible with Windows 8 + If Environment.OSVersion.Version.CompareTo(New Version(6, 2)) >= 0 Then Return False + Dim isPuttyNg As Boolean Try isPuttyNg = FileVersionInfo.GetVersionInfo(file).InternalName.Contains("PuTTYNG") From 84d3f7d30b515d82120ff299804e0fe6343eeb53 Mon Sep 17 00:00:00 2001 From: Riley McArdle Date: Fri, 22 Feb 2013 19:38:43 -0600 Subject: [PATCH 4/5] Fixed KiTTY opening in a separate window when using a saved session. --- CHANGELOG.TXT | 1 + mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.TXT b/CHANGELOG.TXT index 7882723fb..345ab6717 100644 --- a/CHANGELOG.TXT +++ b/CHANGELOG.TXT @@ -8,6 +8,7 @@ Fixed issue MR-322 - Connection Button not listing servers Added option to always show panel tabs Fixed "Decryption failed. Padding is invalid and cannot be removed." notification. + Fixed KiTTY opening in a separate window when using a saved session. 1.70 Beta 2 (2013-02-18): Fixed issue MR-47 - Silent Installation Prompts for Language diff --git a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb index 63ce21209..fc2a711de 100644 --- a/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb +++ b/mRemoteV1/Connection/Connection.Protocol.PuttyBase.vb @@ -163,6 +163,7 @@ Namespace Connection If _isPuttyNg Then PuttyHandle = FindWindowEx(InterfaceControl.Handle, 0, vbNullString, vbNullString) Else + PuttyProcess.Refresh() PuttyHandle = PuttyProcess.MainWindowHandle End If If PuttyHandle.ToInt32 = 0 Then Thread.Sleep(0) From 7c3a349bd612842d2ea336d85ecd3e7de48a43d3 Mon Sep 17 00:00:00 2001 From: Riley McArdle Date: Sat, 23 Feb 2013 21:02:13 -0600 Subject: [PATCH 5/5] Fix typo in CHANGELOG.TXT. --- CHANGELOG.TXT | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.TXT b/CHANGELOG.TXT index 345ab6717..0024e64a2 100644 --- a/CHANGELOG.TXT +++ b/CHANGELOG.TXT @@ -1,3 +1,4 @@ +1.70 (2013-02-22): Fixed issue MR-183 - Error trying to save connections when using SQL - Invalid column name _parentConstantId Fixed issue MR-225 - Tabs do not open in a panel until multiple panels are displayed. Fixed issue MR-229 - Integrated PuTTY doesn't work in Windows 8 RP @@ -6,7 +7,7 @@ Fixed issue MR-318 - Wrong tab gets selected when tab names overflow on the tab bar Fixed issue MR-321 - New connection panel doesn't get panel header if its the only one or is moved Fixed issue MR-322 - Connection Button not listing servers - Added option to always show panel tabs + Added option to always show panel tabs. Fixed "Decryption failed. Padding is invalid and cannot be removed." notification. Fixed KiTTY opening in a separate window when using a saved session.