From fb50cdc0588dafdb0b30c0d330bdb2f6a4bc72f6 Mon Sep 17 00:00:00 2001 From: BlueBlock Date: Thu, 16 Mar 2023 14:35:39 -0400 Subject: [PATCH 1/2] Update PuttySessionsRegistryProvider.cs remove unreachable code - no need to test for null, PuttySessionsKey is a const with a value set on instantiation --- mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs b/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs index 4b655ecfa..1884f7a30 100644 --- a/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs +++ b/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs @@ -24,8 +24,6 @@ namespace mRemoteNG.Config.Putty public override string[] GetSessionNames(bool raw = false) { - if (PuttySessionsKey == null) return null; - var sessionsKey = Registry.CurrentUser.OpenSubKey(PuttySessionsKey); if (sessionsKey == null) return new string[] { }; From cf650d4318d3975408021cf3d668bf74c2c8ade4 Mon Sep 17 00:00:00 2001 From: BlueBlock Date: Thu, 16 Mar 2023 16:10:01 -0400 Subject: [PATCH 2/2] use more efficient array --- mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs b/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs index 1884f7a30..e079d5622 100644 --- a/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs +++ b/mRemoteNG/Config/Putty/PuttySessionsRegistryProvider.cs @@ -25,7 +25,7 @@ namespace mRemoteNG.Config.Putty public override string[] GetSessionNames(bool raw = false) { var sessionsKey = Registry.CurrentUser.OpenSubKey(PuttySessionsKey); - if (sessionsKey == null) return new string[] { }; + if (sessionsKey == null) return Array.Empty(); var sessionNames = new List(); foreach (var sessionName in sessionsKey.GetSubKeyNames())