From 6a4cd708117f9010e2fdbf818dc0ba00bb2b0a2d Mon Sep 17 00:00:00 2001 From: ng3727 <50303390+ng3727@users.noreply.github.com> Date: Tue, 17 Sep 2019 21:43:25 +0100 Subject: [PATCH 1/3] Update CREDITS.md changed gibhub.com urls to be http:// this allows the urls to be clickable --- CREDITS.md | 72 +++++++++++++++++++++++++++--------------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/CREDITS.md b/CREDITS.md index 76e001515..55eaae1a4 100644 --- a/CREDITS.md +++ b/CREDITS.md @@ -1,37 +1,37 @@ # Contributors ## Current mRemoteNG dev team -David Sparer (github.com/sparerd) -Sean Kaim (github.com/kmscode) -Faryan Rezagholi (github.com/farosch) +David Sparer (http://github.com/sparerd) +Sean Kaim (http://github.com/kmscode) +Faryan Rezagholi (http://github.com/farosch) Thanks for the awesome new website! -Bennett Blodinger (github.com/benwa) +Bennett Blodinger (http://github.com/benwa) -Joe Cefoli (github.com/jcefoli) -countchappy (github.com/countchappy) +Joe Cefoli (http://github.com/jcefoli) +countchappy (http://github.com/countchappy) Tony Lambert -Julien Roncaglia (github.com/vbfox) -github.com/peterchenadded -Brandon Wulf (github.com/mrwulf) -Pedro Rodrigues (github.com/pedro2555) -github.com/dekelMP -Bruce (github.com/brucetp) -Camilo Alvarez (github.com/jotatsu) -github.com/DamianBis -github.com/pfjason -github.com/sirLoaf -github.com/Fyers -Vladimir Semenov (github.com/sli-pro) -Stephan (github.com/st-schuler) -Aleksey Reytsman (github.com/areytsman) -Cristian Abelleira (github.com/CrAbelleira) -github.com/MitchellBot +Julien Roncaglia (http://github.com/vbfox) +http://github.com/peterchenadded +Brandon Wulf (http://github.com/mrwulf) +Pedro Rodrigues (http://github.com/pedro2555) +http://github.com/dekelMP +Bruce (http://github.com/brucetp) +Camilo Alvarez (http://github.com/jotatsu) +http://github.com/DamianBis +http://github.com/pfjason +http://github.com/sirLoaf +http://github.com/Fyers +Vladimir Semenov (http://github.com/sli-pro) +Stephan (http://github.com/st-schuler) +Aleksey Reytsman (http://github.com/areytsman) +Cristian Abelleira (http://github.com/CrAbelleira) +http://github.com/MitchellBot ## Past Contributors Felix Deimel - mRemote original developer Riley McArdle - mRemoteNG original developer -Hayato Iriumi (github.com/hiriumi) +Hayato Iriumi (http://github.com/hiriumi) Jason Barbier Wiktor Beryt Lionel Caignec @@ -41,8 +41,8 @@ Tom Hiller Apisitt Rattana Andreas Rehm David Vidmar -github.com/Brandhor -Dimitrij (github.com/Kvarkas) +http://github.com/Brandhor +Dimitrij (http://github.com/Kvarkas) ## Translators Eugenio "Ryo567" Martínez @@ -50,18 +50,18 @@ Mathieu Pape Emanuel Silva Robert Siwiec Hayato Iriumi -Sebastien Thieury (github.com/SebThieu) +Sebastien Thieury (http://github.com/SebThieu) Riza Emet -Lukas Plachy (github.com/rheingold) +Lukas Plachy (http://github.com/rheingold) Gyuha Shin -Stefan (github.com/polluks) -github.com/emazv72 -Vladimir Semenov (github.com/sli-pro) -Marco Sousa (github.com/marcomsousa) -github.com/wwj402 -github.com/Fyers -github.com/pablomh -Damian Szczepanik (github.com/damianszczepanik) +Stefan (http://github.com/polluks) +http://github.com/emazv72 +Vladimir Semenov (http://github.com/sli-pro) +Marco Sousa (http://github.com/marcomsousa) +http://github.com/wwj402 +http://github.com/Fyers +http://github.com/pablomh +Damian Szczepanik (http://github.com/damianszczepanik) ## Included Source Code Command Line Arguments Parser @@ -130,7 +130,7 @@ https://github.com/sshnet/SSH.NET VncSharp Copyright © 2004-2009 David Humphrey GNU General Public License (GPL) Version 2 -https://github.com/humphd/VncSharp +https://github.com/humphd/VncSharp [Archived] ObjectListView Copyright © 2006-2016 Phillip Piper From 55c983c565c23480a87e37610a91e06d12a38abf Mon Sep 17 00:00:00 2001 From: ng3727 <50303390+ng3727@users.noreply.github.com> Date: Tue, 17 Sep 2019 21:45:48 +0100 Subject: [PATCH 2/3] Update AboutWindow.cs fix if the clicked isn't a link, i.e. empty status bar text caused the process start to cause an exception --- mRemoteV1/UI/Window/AboutWindow.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mRemoteV1/UI/Window/AboutWindow.cs b/mRemoteV1/UI/Window/AboutWindow.cs index d1b9356ff..0dd58b0db 100644 --- a/mRemoteV1/UI/Window/AboutWindow.cs +++ b/mRemoteV1/UI/Window/AboutWindow.cs @@ -121,7 +121,9 @@ namespace mRemoteNG.UI.Window private void LinkClicked(object sender, DomMouseEventArgs e) { - Process.Start(((GeckoWebBrowser)sender).StatusText); + string url = ((GeckoWebBrowser)sender).StatusText; + if (url != "") + Process.Start(url); e.Handled = true; } From 7bf00e30e65f4665657e289d20239a163dcac762 Mon Sep 17 00:00:00 2001 From: Faryan Rezagholi Date: Thu, 19 Sep 2019 14:12:22 +0200 Subject: [PATCH 3/3] minor code formatting --- mRemoteV1/UI/Window/AboutWindow.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mRemoteV1/UI/Window/AboutWindow.cs b/mRemoteV1/UI/Window/AboutWindow.cs index 0dd58b0db..16317bb79 100644 --- a/mRemoteV1/UI/Window/AboutWindow.cs +++ b/mRemoteV1/UI/Window/AboutWindow.cs @@ -121,8 +121,8 @@ namespace mRemoteNG.UI.Window private void LinkClicked(object sender, DomMouseEventArgs e) { - string url = ((GeckoWebBrowser)sender).StatusText; - if (url != "") + var url = ((GeckoWebBrowser)sender).StatusText; + if (!string.IsNullOrEmpty(url)) Process.Start(url); e.Handled = true; }