From cc61501f63a5b8391aeeb1fa8a66ffd12c34687d Mon Sep 17 00:00:00 2001 From: David Sparer Date: Thu, 21 Jun 2018 17:35:42 -0500 Subject: [PATCH] dont attempt to delete selected node if it is not a valid deletion target. resolves #1004 --- CHANGELOG.TXT | 1 + mRemoteV1/UI/Controls/ConnectionTree/ConnectionTree.cs | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.TXT b/CHANGELOG.TXT index c8880026..2445e359 100644 --- a/CHANGELOG.TXT +++ b/CHANGELOG.TXT @@ -2,6 +2,7 @@ Fixes: ------ +#1004: Duplicating root or PuTTy node through hotkey causes unhandled exception #1002: Disabling filtering without clearing keyword leaves filtered state #1001: Connection tree context menu hotkeys stop working and disappear in some cases #999: Some hotkeys stop working if File menu was called when PuTTy Saved Sessions was selected diff --git a/mRemoteV1/UI/Controls/ConnectionTree/ConnectionTree.cs b/mRemoteV1/UI/Controls/ConnectionTree/ConnectionTree.cs index 15641417..06de8191 100644 --- a/mRemoteV1/UI/Controls/ConnectionTree/ConnectionTree.cs +++ b/mRemoteV1/UI/Controls/ConnectionTree/ConnectionTree.cs @@ -281,6 +281,10 @@ namespace mRemoteNG.UI.Controls public void DuplicateSelectedNode() { + var selectedNodeType = SelectedNode.GetTreeNodeType(); + if (selectedNodeType != TreeNodeType.Connection && selectedNodeType != TreeNodeType.Container) + return; + var newNode = SelectedNode.Clone(); SelectedNode.Parent.AddChildBelow(newNode, SelectedNode); newNode.Parent.SetChildBelow(newNode, SelectedNode);