From f14fd6bf5acda9a5d58c9112bdce3722af770a85 Mon Sep 17 00:00:00 2001 From: Sean Kaim Date: Sun, 24 Feb 2019 19:26:50 -0500 Subject: [PATCH] Fixes #1314 - hide elements until they are needed Fixes #1314 --- .../MessageWriters/NotificationPanelMessageWriter.cs | 4 ++++ mRemoteV1/UI/Window/ErrorAndInfoWindow.Designer.cs | 6 ++++-- mRemoteV1/UI/Window/ErrorAndInfoWindow.cs | 9 ++++++++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/mRemoteV1/Messages/MessageWriters/NotificationPanelMessageWriter.cs b/mRemoteV1/Messages/MessageWriters/NotificationPanelMessageWriter.cs index 29cb3d44e..82f039679 100644 --- a/mRemoteV1/Messages/MessageWriters/NotificationPanelMessageWriter.cs +++ b/mRemoteV1/Messages/MessageWriters/NotificationPanelMessageWriter.cs @@ -28,7 +28,11 @@ namespace mRemoteNG.Messages.MessageWriters if (_messageWindow.lvErrorCollector.InvokeRequired) _messageWindow.lvErrorCollector.Invoke((MethodInvoker)(() => AddToList(lvItem))); else + { _messageWindow.lvErrorCollector.Items.Insert(0, lvItem); + if (_messageWindow.lvErrorCollector.Items.Count > 0) + _messageWindow.pbError.Visible = true; + } } } } \ No newline at end of file diff --git a/mRemoteV1/UI/Window/ErrorAndInfoWindow.Designer.cs b/mRemoteV1/UI/Window/ErrorAndInfoWindow.Designer.cs index e77d7c375..935583ec8 100644 --- a/mRemoteV1/UI/Window/ErrorAndInfoWindow.Designer.cs +++ b/mRemoteV1/UI/Window/ErrorAndInfoWindow.Designer.cs @@ -1,4 +1,4 @@ - + namespace mRemoteNG.UI.Window { public partial class ErrorAndInfoWindow @@ -16,7 +16,7 @@ namespace mRemoteNG.UI.Window { this.components = new System.ComponentModel.Container(); this.txtMsgText = new mRemoteNG.UI.Controls.Base.NGTextBox(); - this.pbError = new Controls.Base.NGPictureBox(); + this.pbError = new mRemoteNG.UI.Controls.Base.NGPictureBox(this.components); this.lvErrorCollector = new System.Windows.Forms.ListView(); this.clmMessage = ((System.Windows.Forms.ColumnHeader)(new System.Windows.Forms.ColumnHeader())); this.cMenMC = new System.Windows.Forms.ContextMenuStrip(this.components); @@ -33,6 +33,7 @@ namespace mRemoteNG.UI.Window // txtMsgText // this.txtMsgText.BorderStyle = System.Windows.Forms.BorderStyle.None; + this.txtMsgText.Font = new System.Drawing.Font("Segoe UI", 8.25F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(0))); this.txtMsgText.Location = new System.Drawing.Point(40, 19); this.txtMsgText.Multiline = true; this.txtMsgText.Name = "txtMsgText"; @@ -51,6 +52,7 @@ namespace mRemoteNG.UI.Window this.pbError.SizeMode = System.Windows.Forms.PictureBoxSizeMode.CenterImage; this.pbError.TabIndex = 0; this.pbError.TabStop = false; + this.pbError.Visible = false; // // lvErrorCollector // diff --git a/mRemoteV1/UI/Window/ErrorAndInfoWindow.cs b/mRemoteV1/UI/Window/ErrorAndInfoWindow.cs index 0e7ec2160..224503999 100644 --- a/mRemoteV1/UI/Window/ErrorAndInfoWindow.cs +++ b/mRemoteV1/UI/Window/ErrorAndInfoWindow.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Drawing; using System.Collections; using System.Globalization; @@ -296,6 +296,7 @@ namespace mRemoteNG.UI.Window { cMenMCCopy.Enabled = true; cMenMCDelete.Enabled = true; + pbError.Visible = true; } else { @@ -387,6 +388,12 @@ namespace mRemoteNG.UI.Window { lvErrorCollector.Items.Clear(); } + + if (lvErrorCollector.Items.Count == 0) + { + pbError.Visible = false; + txtMsgText.Visible = false; + } } catch (Exception ex) {