mirror of
https://github.com/rustdesk/rustdesk.git
synced 2026-02-17 22:11:30 +08:00
0d31071e18
- Clarify that size-based rotation is already implemented - Update line numbers to match actual code location (line 407) - Mark patch as reference since changes are already applied - Remove misleading "recommended enhancement" language Co-authored-by: rustdesk <71636191+rustdesk@users.noreply.github.com>
Patches for hbb_common
This directory contains patches for reference. The changes described have already been applied to the hbb_common submodule in this PR.
hbb_common-log-rotation.patch
Status: ✅ Already applied in this PR (submodule commit 0c401fd)
Purpose: Add size-based log rotation to prevent excessive disk usage
Apply to: libs/hbb_common submodule
Target repository: https://github.com/rustdesk/hbb_common
Reference Information
This patch file is provided for:
- Documentation of the exact changes made
- Reference for maintainers
- Potential cherry-picking to other branches if needed
The changes have already been implemented in the submodule updated by this PR.
What it does
- Changes log rotation from age-only to age-or-size based
- Rotates logs when they reach 100MB OR daily (whichever comes first)
- Limits total log storage to ~3.1GB (31 files × 100MB max each)
- Prevents runaway log files from consuming excessive disk space
Testing
After applying the patch and rebuilding:
- Verify logs are created in the standard location
- Check that individual log files don't exceed 100MB
- Confirm old files are still cleaned up after 31 days
- Ensure log content is still complete and useful
See ../LOG_MANAGEMENT.md for complete documentation.