Learning/mRemoteNG
1
0
Fork 0
mirror of https://github.com/mRemoteNG/mRemoteNG.git synced 2026-02-17 22:11:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address code review feedback - optimize regex and use Array.Empty

Browse Source 
Co-authored-by: Kvarkas <3611964+Kvarkas@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-30 12:16:52 +00:00
parent c683854678
commit 76cb0a1e0b
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mRemoteNGInstaller/CustomActions/InstalledWindowsUpdateChecker.cs
View File

@@ -9,6 +9,7 @@ namespace CustomActions
public class InstalledWindowsUpdateChecker
{
private readonly ManagementScope _managementScope;
private static readonly Regex KbPattern = new Regex(@"^(KB)?\d+$", RegexOptions.IgnoreCase | RegexOptions.Compiled);
public InstalledWindowsUpdateChecker()
{
@@ -88,12 +89,9 @@ namespace CustomActions
// KB IDs should match the pattern: KB followed by digits (e.g., KB1234567)
// or just digits (e.g., 1234567)
// This regex allows optional "KB" prefix followed by one or more digits
var kbPattern = new Regex(@"^(KB)?\d+$", RegexOptions.IgnoreCase);
// Trim whitespace and check if it matches the expected pattern
var trimmedKb = kbId.Trim();
if (!kbPattern.IsMatch(trimmedKb))
if (!KbPattern.IsMatch(trimmedKb))
return string.Empty;
// Return the sanitized value (uppercased for consistency)

2
mRemoteNGTests/Installer/InstalledWindowsUpdateCheckerTests.cs
View File

@@ -157,7 +157,7 @@ namespace mRemoteNGTests.Installer
[Test]
public void BuildWhereClause_EmptyList_ReturnsEmpty()
{
var result = InvokeBuildWhereClause(new string[0]);
var result = InvokeBuildWhereClause(Array.Empty<string>());
Assert.That(result, Is.Empty);
}