Learning/mRemoteNG
1
0
Fork 0
mirror of https://github.com/mRemoteNG/mRemoteNG.git synced 2026-02-17 22:11:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refactored ConnectionTree.DeleteSelectedNode() - extracted some methods to make it more readable

Browse Source
This commit is contained in:
David Sparer
2016-05-27 11:18:05 -06:00
parent 5c7f120a7e
commit eab5a42d93
1 changed files with 42 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
mRemoteV1/Tree/ConnectionTree.cs
View File

@@ -38,25 +38,19 @@ namespace mRemoteNG.Tree
{
try
{
if (SelectedNode == null)
if (!SelectedNodeIsAValidDeletionTarget())
return;
if (ConnectionTreeNode.GetNodeType(SelectedNode) == TreeNodeType.Root)
{
Runtime.MessageCollector.AddMessage(MessageClass.WarningMsg, "The root item cannot be deleted!");
}
else if (ConnectionTreeNode.GetNodeType(SelectedNode) == TreeNodeType.Container)
if (ConnectionTreeNode.GetNodeType(SelectedNode) == TreeNodeType.Container)
{
if (ConnectionTreeNode.IsEmpty(SelectedNode))
{
if (Interaction.MsgBox(string.Format(Language.strConfirmDeleteNodeFolder, SelectedNode.Text), MsgBoxStyle.YesNo | MsgBoxStyle.Question, null) == MsgBoxResult.Yes)
{
if (UserConfirmsEmptyFolderDeletion())
SelectedNode.Remove();
}
}
else
{
if (Interaction.MsgBox(string.Format(Language.strConfirmDeleteNodeFolderNotEmpty, SelectedNode.Text), MsgBoxStyle.YesNo | MsgBoxStyle.Question, null) == MsgBoxResult.Yes)
if (UserConfirmsNonEmptyFolderDeletion())
{
foreach (TreeNode tNode in SelectedNode.Nodes)
{
@@ -68,10 +62,8 @@ namespace mRemoteNG.Tree
}
else if (ConnectionTreeNode.GetNodeType(SelectedNode) == TreeNodeType.Connection)
{
if (Interaction.MsgBox(string.Format(Language.strConfirmDeleteNodeConnection, SelectedNode.Text), MsgBoxStyle.YesNo | MsgBoxStyle.Question, null) == MsgBoxResult.Yes)
{
if (UserConfirmsConnectionDeletion())
SelectedNode.Remove();
}
}
else
{
@@ -84,6 +76,43 @@ namespace mRemoteNG.Tree
}
}
private static bool SelectedNodeIsAValidDeletionTarget()
{
bool validDeletionTarget = true;
if (SelectedNode == null)
validDeletionTarget = false;
else if (ConnectionTreeNode.GetNodeType(SelectedNode) == TreeNodeType.Root)
{
validDeletionTarget = false;
Runtime.MessageCollector.AddMessage(MessageClass.WarningMsg, "The root item cannot be deleted!");
}
return validDeletionTarget;
}
private static bool UserConfirmsEmptyFolderDeletion()
{
string messagePrompt = string.Format(Language.strConfirmDeleteNodeFolder, SelectedNode.Text);
return PromptUser(messagePrompt);
}
private static bool UserConfirmsNonEmptyFolderDeletion()
{
string messagePrompt = string.Format(Language.strConfirmDeleteNodeFolderNotEmpty, SelectedNode.Text);
return PromptUser(messagePrompt);
}
private static bool UserConfirmsConnectionDeletion()
{
string messagePrompt = string.Format(Language.strConfirmDeleteNodeConnection, SelectedNode.Text);
return PromptUser(messagePrompt);
}
private static bool PromptUser(string PromptMessage)
{
MsgBoxResult msgBoxResponse = Interaction.MsgBox(PromptMessage, MsgBoxStyle.YesNo | MsgBoxStyle.Question, null);
return (msgBoxResponse == MsgBoxResult.Yes);
}
public static void StartRenameSelectedNode()
{
if (SelectedNode != null)