added some more tests

This commit is contained in:
David Sparer
2017-01-13 17:43:06 -07:00
parent 05d8b7983a
commit fd7adf3c64
4 changed files with 32 additions and 2 deletions

View File

@@ -1,5 +1,6 @@
using System;
using mRemoteNG.Connection;
using mRemoteNG.Container;
using mRemoteNG.Tree;
using NSubstitute;
using NUnit.Framework;
@@ -27,11 +28,24 @@ namespace mRemoteNGTests.Tree
_connectionInitiator.Received().OpenConnection(connectionInfo);
}
[Test]
public void DoesNothingWhenGivenContainerInfo()
{
_clickHandler.Execute(new ContainerInfo());
_connectionInitiator.DidNotReceiveWithAnyArgs().OpenConnection(new ConnectionInfo());
}
[Test]
public void ExceptionThrownWhenConstructorGivenNullArg()
{
// ReSharper disable once ObjectCreationAsStatement
Assert.Throws<ArgumentNullException>(() => new OpenConnectionClickHandler(null));
}
[Test]
public void ThrowWhenExecuteGivenNullArg()
{
Assert.Throws<ArgumentNullException>(() => _clickHandler.Execute(null));
}
}
}

View File

@@ -1,5 +1,6 @@
using System;
using mRemoteNG.Connection;
using mRemoteNG.Container;
using mRemoteNG.Tree;
using NSubstitute;
using NUnit.Framework;
@@ -27,11 +28,24 @@ namespace mRemoteNGTests.Tree
_connectionInitiator.Received().SwitchToOpenConnection(connectionInfo);
}
[Test]
public void DoesNothingWhenGivenContainerInfo()
{
_clickHandler.Execute(new ContainerInfo());
_connectionInitiator.DidNotReceiveWithAnyArgs().SwitchToOpenConnection(new ConnectionInfo());
}
[Test]
public void ExceptionThrownWhenConstructorGivenNullArg()
{
// ReSharper disable once ObjectCreationAsStatement
Assert.Throws<ArgumentNullException>(() => new SwitchToConnectionClickHandler(null));
}
[Test]
public void ThrowWhenExecuteGivenNullArg()
{
Assert.Throws<ArgumentNullException>(() => _clickHandler.Execute(null));
}
}
}

View File

@@ -17,7 +17,8 @@ namespace mRemoteNG.Tree
public void Execute(ConnectionInfo clickedNode)
{
if (clickedNode == null) return;
if (clickedNode == null)
throw new ArgumentNullException(nameof(clickedNode));
if (clickedNode.GetTreeNodeType() != TreeNodeType.Connection && clickedNode.GetTreeNodeType() != TreeNodeType.PuttySession) return;
_connectionInitiator.OpenConnection(clickedNode);
}

View File

@@ -17,7 +17,8 @@ namespace mRemoteNG.Tree
public void Execute(ConnectionInfo clickedNode)
{
if (clickedNode == null) return;
if (clickedNode == null)
throw new ArgumentNullException(nameof(clickedNode));
if (clickedNode.GetTreeNodeType() != TreeNodeType.Connection && clickedNode.GetTreeNodeType() != TreeNodeType.PuttySession) return;
_connectionInitiator.SwitchToOpenConnection(clickedNode);
}