Learning/s7netplus
0
0
Fork 0
mirror of https://github.com/S7NetPlus/s7netplus.git synced 2026-02-17 22:38:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Removed redundant WriteMultipleBytes method.

Browse Source 
Signed-off-by: Michele Cattafesta <michele.cattafesta@mesta-automation.com>
This commit is contained in:
Michele Cattafesta
2016-09-12 23:11:16 +02:00
parent d9d2c19dcd
commit 8b8b96797f
1 changed files with 2 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
S7.Net/PLC.cs
View File

@@ -803,7 +803,7 @@ namespace S7.Net
public ErrorCode WriteStruct(object structValue, int db, int startByteAdr = 0)
{
var bytes = Types.Struct.ToBytes(structValue).ToList();
var errCode = WriteMultipleBytes(bytes, db, startByteAdr);
var errCode = WriteBytes(DataType.DataBlock ,db, startByteAdr, bytes.ToArray());
return errCode;
}
@@ -817,7 +817,7 @@ namespace S7.Net
public ErrorCode WriteClass(object classValue, int db, int startByteAdr = 0)
{
var bytes = Types.Class.ToBytes(classValue).ToList();
var errCode = WriteMultipleBytes(bytes, db, startByteAdr);
var errCode = WriteBytes(DataType.DataBlock, db, startByteAdr, bytes.ToArray());
return errCode;
}
@@ -830,40 +830,6 @@ namespace S7.Net
LastErrorString = string.Empty;
}
/// <summary>
/// Writes multiple bytes to the plc. This uses recursion and it's not limited to 200 bytes.
/// </summary>
/// <param name="bytes">The bytes values to be written</param>
/// <param name="db">Db address</param>
/// <param name="startByteAdr">Start bytes on the plc</param>
/// <returns>NoError if it was successful, or the error is specified</returns>
private ErrorCode WriteMultipleBytes(List<byte> bytes, int db, int startByteAdr = 0)
{
ErrorCode errCode = ErrorCode.NoError;
int index = startByteAdr;
try
{
while (bytes.Count > 0)
{
var maxToWrite = Math.Min(bytes.Count, 200);
var part = bytes.ToList().GetRange(0, maxToWrite);
errCode = WriteBytes(DataType.DataBlock, db, index, part.ToArray());
bytes.RemoveRange(0, maxToWrite);
index += maxToWrite;
if (errCode != ErrorCode.NoError)
{
break;
}
}
}
catch(Exception exc)
{
LastErrorCode = ErrorCode.WriteData;
LastErrorString = "An error occurred while writing data:" + exc.Message;
}
return errCode;
}
/// <summary>
/// Creates the header to read bytes from the plc
/// </summary>