Provide a clear message on Encoding.ASCII.GetString exceptions

2026-02-17 22:38:27 +08:00 · 2018-07-31 21:32:41 +02:00
parent 93752a3485
commit cf64c65c23
1 changed files with 11 additions and 1 deletions
--- a/S7.Net/Types/StringEx.cs
+++ b/S7.Net/Types/StringEx.cs
@@ -22,7 +22,17 @@ namespace S7.Net.Types
            int size = bytes[0];
            int length = bytes[1];

-            return System.Text.Encoding.ASCII.GetString(bytes, 2, length);
+            try
+            {
+                return Encoding.ASCII.GetString(bytes, 2, length);
+            }
+            catch (Exception e)
+            {
+                throw new PlcException(ErrorCode.ReadData,
+                    $"Failed to parse {VarType.StringEx} from data. Following fields were read: size: '{size}', actual length: '{length}', total number of bytes (including header): '{bytes.Length}'.",
+                    e);
+            }
+            
        }

        /// <summary>